Repository navigation
TRD: update of T0 value and possibility to disable shift in the tracklet transformer - #16104
Merged
Merged
Conversation
glegras
commented
Nov 11, 2026
glegras
commented
Contributor
- T0 in MC is updated to reproduce better pulse height plot, then t0 in reconstruction is updated to give the best residuals in MC (only small shift, to be absorbed in the alignment for data)
- Adding option to disable the shift by one pad in data in the tracklet transformer, in case we don't want it to be absorbed in the alignment anymore
- Update of the pile-up correction of tracklet y position to take into account average correction rather than most probable one
- The one pad shift is only a problem in the geometrical position, the pad number is correct without applying this shift
glegras
requested review from
a team,
bazinski,
davidrohr,
f3sch and
wille10
as code owners
November 11, 2026 11:40
shahor02
reviewed
Nov 11, 2026
| @@ -276,11 +276,15 @@ bool Digitizer::convertHits(const int det, const std::vector<Hit>& hits, SignalC | |||
| } | |||
| } | |||
|
|
|||
| if (hit.GetTrackID() < 20) | |||
Collaborator
There was a problem hiding this comment.
Do you really need these logs in every MC job?
BTW, the code checker requires {} even for 1-liners.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 27b4458 at 2026-11-11 15:40: Full log here. |
shahor02
approved these changes
Nov 11, 2026
Collaborator
|
Formatting CI errors are on the server side, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.